Skip to content

PMM-14360 Disk I/O Total output is incorrect#5222

Open
igroene wants to merge 2 commits intov3from
PMM-14360
Open

PMM-14360 Disk I/O Total output is incorrect#5222
igroene wants to merge 2 commits intov3from
PMM-14360

Conversation

@igroene
Copy link
Copy Markdown
Member

@igroene igroene commented Apr 7, 2026

Applied the changes from upstream PR percona/grafana-dashboards#1787 to this repo.

Updated files:

  • MongoDB/MongoDB_InMemory_Details.json
  • MongoDB/MongoDB_Instance_Summary.json
  • MongoDB/MongoDB_ReplSet_Summary.json
  • MongoDB/MongoDB_WiredTiger_Details.json

What changed:

  • Replaced the broken Total disk I/O PromQL expression in each dashboard.
  • The new query correctly computes:
    • reads: container fs reads or page-in fallback
    • writes: container fs writes or page-out fallback
    • total: reads + writes

@igroene igroene requested review from a team and Nailya as code owners April 7, 2026 16:09
@igroene igroene requested review from fabio-silva and matejkubinec and removed request for a team April 7, 2026 16:09
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.46%. Comparing base (38c9b56) to head (dcca9c9).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #5222      +/-   ##
==========================================
- Coverage   47.79%   47.46%   -0.34%     
==========================================
  Files         410      540     +130     
  Lines       41981    44325    +2344     
  Branches        0      584     +584     
==========================================
+ Hits        20066    21038     +972     
- Misses      19940    21248    +1308     
- Partials     1975     2039      +64     
Flag Coverage Δ
admin 35.80% <ø> (ø)
agent 53.36% <ø> (+0.01%) ⬆️
unittests 41.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant