Conversation
28d6595 to
9a6635a
Compare
6c55e1b to
cc967a3
Compare
artemgavrilov
approved these changes
Nov 13, 2025
JiriCtvrtka
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant updates to the project's CI configuration, code formatting, linting, and ownership files. The main goals are to modernize CI workflows, improve code quality enforcement, and update project ownership.
Key changes include:
CI/CD Workflow Modernization
.github/workflows/ci.ymlto use newer GitHub Actions (e.g.,actions/checkout,actions/setup-go,actions/cache) and switched runners toubuntu-22.04. The Go version matrix and related logic were removed in favor of using the version fromgo.mod. Steps for formatting, linting, and caching are now more standardized and robust. Debug output is improved for easier troubleshooting. [1] [2] [3].github/workflows/clean.ymlworkflow, which previously handled scheduled cache cleaning.Linting and Formatting Configuration
.golangci.ymlto a new format with explicit linter enables/disables, improved rules, and formatter settings. This enhances consistency and clarity in code quality checks..golangci-required.yml(previously used for required linters) and added.golangci.bck.ymlas a backup configuration for almost-all linters, with comments explaining exclusions. [1] [2]Makefileto usegofumptandgoimportsfor formatting all.gofiles, improving code style consistency.Project Ownership
.github/CODEOWNERSfrom@artemgavrilovto@ademidoff.Code Quality and Testing Improvements
alertmanager/config_test.goby removing unnecessary address-of (&) usage, switching torequire.NoErrorfor better test failure reporting, and minor refactoring for clarity. [1] [2] [3] [4] [5] [6] [7] [8]AlertingConfiginalerting.go.//nolint:intrangecomments to suppress linter warnings for loop index types incopy.go. [1] [2]copy_test.goto avoid using the unsafe package, making the test safer and more idiomatic.