refactor: extract shared utilities from duplicated gmail/outlook code#4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
refactor: extract shared utilities from duplicated gmail/outlook code#4devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Create permit0-mcp-shared package with three modules: - http.AuthenticatedClient: token-based HTTP wrapper (was duplicated in gmail.py and graph.py) - server.create_server/run_server: FastMCP creation and MCP_TRANSPORT dispatch (was duplicated in both server.py main() functions) - response.to_json: json.dumps(obj, indent=2, ensure_ascii=False) helper (was repeated ~25 times across both server.py files) Update both servers to import from the shared package. Update Dockerfiles to use repo-root build context so the shared package is available during image builds. Update docker-compose.yml accordingly. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
gmail-mcpandoutlook-mcpduplicated three patterns. This PR extracts them into a newshared/permit0_mcp_sharedpackage.What was duplicated → what it became:
gmail.pyandgraph.pyeach had ~15 identical lines (get token → build headers →httpx.request→ error check → return json)AuthenticatedClient(base_url, error_label, get_token)inpermit0_mcp_shared.httpserver.pyhad identicalFastMCP(name, host=env(…), port=env(…))+ identicalmain()functioncreate_server(name)andrun_server(server)inpermit0_mcp_shared.serverjson.dumps(obj, indent=2, ensure_ascii=False)repeated ~25× across both serversto_json(obj)inpermit0_mcp_shared.responseUsage after refactoring (gmail.py as example):
Docker build context changed from per-package (
gmail-mcp/) to repo root (.) so the shared package is available duringCOPY. Dockerfiles anddocker-compose.ymlupdated accordingly; thedocker buildcommands inREADME.mdanddocs/are updated too.Both servers still register exactly 13 tools each — verified by importing and counting.
Link to Devin session: https://app.devin.ai/sessions/88887f3b436449c2923a19a56c1c5c88
Requested by: @fafaisland