Skip to content

[WIP] Travis CI#60

Open
aapeliv wants to merge 16 commits into
masterfrom
feature-travis-ci
Open

[WIP] Travis CI#60
aapeliv wants to merge 16 commits into
masterfrom
feature-travis-ci

Conversation

@aapeliv
Copy link
Copy Markdown
Collaborator

@aapeliv aapeliv commented Nov 29, 2018

No description provided.

@aapeliv
Copy link
Copy Markdown
Collaborator Author

aapeliv commented Nov 29, 2018

Need to sort out code generation

@shuttle1987
Copy link
Copy Markdown
Member

Basically fetch exists in the browser but not in node. So I've installed isomorphic-fetch package and overrode the global.fetch with this in the tests. However something is still not working here and I have no idea why.

@shuttle1987
Copy link
Copy Markdown
Member

shuttle1987 commented Nov 29, 2018

Right now the set up for the Jest test running startup fixture is not configured. This is because the app hasn't been ejected from the starter yet and hence I can't update the config to point Jest to the startup fixture.

@aapeliv
Copy link
Copy Markdown
Collaborator Author

aapeliv commented Nov 30, 2018

Thanks for working on this. Do you have a clue on how to take this further?

@shuttle1987
Copy link
Copy Markdown
Member

The main issue here comes down to the fact that the Travis setup is headless and this all runs in the browser, so we have to mock the browser specific things like global.fetch in order to be able to run the tests in the nodejs based environment.

So I think we may have to eject the project from the starter if we want to create a test setup fixture that sets these mocks up.

Mostly what I'd want to run in Travis is linting and static analysis however so if we don't run tests in Travis that's not an issue. We could add linting and add type checking while disabling the testing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants