Skip to content

[ENHANCEMENT] cache perses clients and cleanup metrics when resources are deleted#414

Draft
jgbernalp wants to merge 1 commit into
mainfrom
improve-memory-consumption
Draft

[ENHANCEMENT] cache perses clients and cleanup metrics when resources are deleted#414
jgbernalp wants to merge 1 commit into
mainfrom
improve-memory-consumption

Conversation

@jgbernalp
Copy link
Copy Markdown
Contributor

Description

This PR:

  • Fixes a memory leak with the metrics when resources are deleted
  • Caches the Perses clients created by the client factory to improve memory consumption and avoid creating a client for each reconcile request

Type of change

  • FEATURE (non-breaking change which adds functionality)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • BREAKINGCHANGE (fix or feature that would cause existing functionality to not work as expected)
  • DOC (documentation only)
  • IGNORE (tooling, build system, CI, etc.)

Verification

  • Unit tests added/updated
  • Integration tests added/updated
  • E2E tests added/updated
  • Manual testing performed

Checklist

  • Pull request has a descriptive title and context useful to a reviewer
  • Code follows project conventions and passes linting
  • All commits have DCO signoffs

… are deleted

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant