feat: remove high cardinality metric labels #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenliang-CHEN
force-pushed
the
v2.268.0-light-metrics
branch
5 times, most recently
from
28009dc to
0c792d6
Compare
This MR removes these labels from the fmtLabel implementation of Outbound/InboundEndpointMetrics These metrics will be removed: target_addr, dst_pod, dst_pod_template_hash, dst_zone, authority They are all metrics with high cardinality This MR also reduces the number of buckets for response_latency_bucket_ms metric. It will use another approach for the larger buckets: instead of deleting buckets in a roll, it will buckets alternately
Wenliang-CHEN
force-pushed
the
v2.268.0-light-metrics
branch
from
0c792d6 to
52ae2e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR removes these labels from the fmtLabel implementation of Outbound/InboundEndpointMetrics
These metrics will be removed: target_addr, dst_pod, dst_pod_template_hash, dst_zone, authority
They are all metrics with high cardinality
This MR also reduces the number of buckets for response_latency_bucket_ms metric.
It will use another approach for the larger buckets: instead of deleting buckets in a roll, it will buckets alternately