Avoid using compile configuration for Gradle#22
Open
sigv wants to merge 1 commit into
Open
Conversation
The existing suggestion for using `compile` dependencies has been discouraged with Gradle 3.4 way way back. > instead of compile, you should use one of implementation or api https://docs.gradle.org/3.4/release-notes.html#the-java-library-plugin On a recent Gradle version you will see a scary deprecation warning. > Deprecated Gradle features were used in this build, > making it incompatible with Gradle 7.0. Upon turning on `--warning-mode all` you will discover it is exactly about that `compile` declaration that is suggested. > The compile configuration has been deprecated for dependency > declaration. This will fail with an error in Gradle 7.0. This commit simply swaps the `compile` out for an `implementation`. https://docs.gradle.org/6.6/userguide/java_library_plugin.html#sec:java_library_configurations_graph
sigv
force-pushed
the
gradle-compile-implementation
branch
from
686f200 to
34ad30d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing suggestion for using
compiledependencies has been discouraged with Gradle 3.4 way way back.On a recent Gradle version you will see a scary deprecation warning.
Upon turning on
--warning-mode allyou will discover it is exactly about thatcompiledeclaration that is suggested.This PR simply swaps the
compileout for animplementation.The Java Library plugin configurations (The Java Library Plugin - Gradle 6.6 User Manual)
If there is a script which writes that file, I wasn't able to find it linked, and that should be updated as well to use
implementationinstead ofcompile.