add support for MS timezone names, and support for TZ not UTC (said ToDo)#114
Open
sdetweil wants to merge 6 commits into
Open
add support for MS timezone names, and support for TZ not UTC (said ToDo)#114sdetweil wants to merge 6 commits into
sdetweil wants to merge 6 commits into
Conversation
Contributor
Author
|
i think this PR will fail for the same reason as #111 , as I add a dependency (install time, and a file to read at runtime) |
DennisGaida
reviewed
Oct 25, 2023
| function getIanaTZFromMS(msTZName){ | ||
| if(!zoneTable){ | ||
| const fs=require('fs') | ||
| const wtz=JSON.parse(fs.readFileSync(__dirname+"/windowsZones.json")) |
There was a problem hiding this comment.
You did not include the file windowsZones.json in your commit.
Contributor
Author
|
@DennisGaida I don't understand.. its been in the repo for a long time.. I provided it back in 2020 |
Contributor
Author
|
i do not see the file in the current file list, but the last commit related to the the file was in 2021. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ms timezones are different from IANA. there is a table maintained by unicode.org that maps to IANA timezones. (xml format)
add post install to download and convert (using xml-js module) to json, so file is present if needed
add support to load table as lookup IF ms timezones are detected (they have spaces), and use it to map back to IANA
added test ics and testcase
use moment-timezone to set date per the ics w timezone, which gets date() in utc as required.
also handles (????+offset) timezones..
also TZID="america/pacific:20201005080000" (#65)
fixes #50 #65 #68 #76 #115