Add @types/node-ical#98
Open
hugoblanc wants to merge 100 commits into
Open
Conversation
Although the original comment said nobody uses those, Google sent me one today (TZID="(UTC-05:00) America/New_York", whatever that might mean). Changed the split to a regexp.
Conflicts: package.json
eg. if we have the following in an ical ``` FREEBUSY;FBTYPE=FREE: ``` We ultimately end up with no start and end date values and it blows up trying to replace the strings on undefined
Added better support for Recurrence Rules: - Updates to specific recurrences of events now get their own entries in a recurrences[] array, keyed by ISO date/time. (Previously, their records silently overwrote the main recurrence event) - Exceptions to recurrences now appear in an exdate[] array, keyed by ISO date/time. Also added "knowledge" of the dtstamp, created, and lastmodified fields so that they get stored as dates, not strings. This should solve issues #57 and #63.
Code maintenance problems: * Example.js should be pointing to node-ical, not ical now. * ical should depend on rrule 2.1.0 or greater due to dependency issues with underscore Added tests: * Verify that a recurrence-id doesn't overwrite the main entry * Verify that exdates appear in the exdate array * Verify that recurrence-id entries appear in the recurrences array * Verify that the arrays are keyed by ISO date strings
ignore time if type is date; add date type info
Add Time Zone Support
Refactor and Improve API
Add typescript types
ignored the removal of request as it is definitly required but needs to be replaced by something else of course. Merge remote-tracking branch 'upstream/master'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-ical.d.ts
export function fromURL(url: any, opts: any, cb: any): void;
export function handleObject(name: any, val: any, params: any, ctx: any, stack: any, line: any): any;
export namespace objectHandlers {
function BEGIN(component: any, params: any, curr: any, stack: any): any;
function CATEGORIES(val: any, params: any, curr: any): any;
function COMPLETED(val: any, params: any, curr: any): any;
function CREATED(val: any, params: any, curr: any): any;
function DESCRIPTION(val: any, params: any, curr: any): any;
function DTEND(val: any, params: any, curr: any): any;
function DTSTAMP(val: any, params: any, curr: any): any;
function DTSTART(val: any, params: any, curr: any): any;
function END(val: any, params: any, curr: any, stack: any): any;
function EXDATE(val: any, params: any, curr: any): any;
function FREEBUSY(val: any, params: any, curr: any): any;
function GEO(val: any, params: any, curr: any): any;
function LOCATION(val: any, params: any, curr: any): any;
function RRULE(val: any, params: any, curr: any, stack: any, line: any): any;
function SUMMARY(val: any, params: any, curr: any): any;
function TRANSP(val: any, params: any, curr: any): any;
function UID(val: any, params: any, curr: any): any;
function URL(val: any, params: any, curr: any): any;
}
export function parseFile(filename: any, cb: any): any;
export function parseICS(str: any, cb: any): any;
export function parseLines(lines: any, limit: any, ctx: any, stack: any, lastIndex: any, cb: any): any;
Sorry, I don't have time to set correct types, but this file make your lib works with typescript