Add option to promote subteams to Teams directory (#432)#187
Open
peterdrier wants to merge 2 commits intomainfrom
Open
Add option to promote subteams to Teams directory (#432)#187peterdrier wants to merge 2 commits intomainfrom
peterdrier wants to merge 2 commits intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
peterdrier
force-pushed
the
sprint/2026-04-08/batch-6
branch
from
77ac2eb to
38a1656
Compare
|
The preview deployment for humans-qa failed. 🔴 Open Build Logs | Open Application Logs Last updated at: 2026-04-09 16:30:41 CET |
|
The preview deployment for humans-qa is ready. 🟢 Open Preview | Open Build Logs | Open Application Logs Last updated at: 2026-04-13 16:18:27 CET |
Owner
Author
Release Review — Issues Found
I would not release this to production until that public-path mismatch is fixed. |
peterdrier
force-pushed
the
sprint/2026-04-08/batch-6
branch
from
38a1656 to
01cc542
Compare
peterdrier
added a commit
that referenced
this pull request
Apr 13, 2026
Subteams cannot have IsPublicPage (forced false in UpdateTeamAsync), so the anon filter that required IsPublicPage excluded promoted subteams entirely. Treat IsPromotedToDirectory as the subteam-equivalent opt-in, and let anon visitors reach a promoted subteam's detail page so the directory link works. Addresses review on PR #187. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Fixed in c4650f0. Root cause: the anonymous directory filter required Fix:
Build + |
…e#432) - Add IsPromotedToDirectory property to Team entity (default false) - Add IsInDirectory computed property encapsulating visibility logic - Filter /Teams directory to show only top-level teams and promoted subteams - Add "Show on Teams page" checkbox in team edit (visible for subteams only) - Include EF migration for new column - Update feature docs and section invariants Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Subteams cannot have IsPublicPage (forced false in UpdateTeamAsync), so the anon filter that required IsPublicPage excluded promoted subteams entirely. Treat IsPromotedToDirectory as the subteam-equivalent opt-in, and let anon visitors reach a promoted subteam's detail page so the directory link works. Addresses review on PR #187. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
peterdrier
force-pushed
the
sprint/2026-04-08/batch-6
branch
from
c4650f0 to
46cba8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsPromotedToDirectoryproperty to Team entity (defaultfalse)IsInDirectorycomputed property encapsulating visibility logic/Teamsdirectory to show only top-level teams and promoted subteamsCloses nobodies-collective#432
Test plan
/Teamsshows only top-level teams by default (subteams no longer clutter directory)/Teams/Teams/Teamsview also respects the flag🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com