Quiet expected error logs (#497, #499, #500)#226
Merged
peterdrier merged 3 commits intomainfrom Apr 15, 2026
Merged
Conversation
- nobodies-collective#497: Catch OperationCanceledException in ProfileController.Picture and return 499 without logging when the client aborted. - nobodies-collective#499: Drop LogWarning wrapping ValidationException from UserEmailService.AddEmailAsync; user-input validation is expected. - nobodies-collective#500: Drop LogWarning wrapping "cannot delete shift with signups" in ShiftAdminController.DeleteShift; this is an expected guardrail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previous commit deleted the log calls entirely; we still want a record of these problems in the log — just without the exception object/stack trace and at a lower severity than Warning. - ProfileController.Picture: LogInformation on client-cancelled request - ProfileController.AddEmail: LogInformation on rejected email add - ShiftAdminController.DeleteShift: LogInformation on rejected delete Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previous commit downgraded these to LogInformation, but the production log viewer only renders Warning and above, so Information-level logs are effectively invisible in prod. Keep LogWarning; the value is that the exception object is no longer attached (no stack trace spam) while the event is still visible to whoever watches the prod log viewer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The preview deployment for humans-qa failed. 🔴 Open Build Logs | Open Application Logs Last updated at: 2026-04-15 12:39:56 CET |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OperationCanceledExceptioninProfileController.Pictureand return 499 when the client aborted — stops error-log spam.LogWarningwrappingValidationExceptionfromAddEmailAsync. User-input validation is expected, not a warning condition.LogWarningwrapping "cannot delete shift with signups"InvalidOperationException. This is an expected guardrail hit via the UI.Test plan
🤖 Generated with Claude Code