cleanup and fixed build failures#1
Open
rfc6919 wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure if this is all correct, but...
firmware/final contained the same built firmware as was loaded on the badges. I've hoisted that to firmware/ assuming that firmware/u8g2test was early junk
removed absolute path references to your machine
did some cleanup (delete/ignore junk and build products, uniform eof, strip trailing whitespace)
firmware/Libraries/ugfx (aka firmware/final/Libraries/ugfx) didn't build, looked unconfigured. firmware/u8g2test/Libraries/ugfx looked configured, so pulled that in
it now builds, but built firmware doesn't behave like the deployed firmware. I'm wondering if /home/peter/src/OzSecCon_Badge_Dev/LCDTest/Libraries/ugfx (referenced from firmware/final/Libraries/Makefile) is configured differently to either of the provided ugfx libraries? or if I've missed something else?