fix: keyboard shortcuts in packaged app - #232
Open
Dhruv-Sharma29 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Shortcut/event-order changes in a packaged desktop WebView context are hard to validate here (and the frontend build/tests were not run), so a human verification pass is warranted.
Pull request overview
This PR adjusts the frontend keyboard shortcut listener so application shortcuts remain reliable in the packaged Tauri desktop app, particularly when focus is inside Monaco/WebView-controlled elements.
Changes:
- Register the window
keydownlistener in the capture phase to avoid missing events swallowed during bubbling. - Skip shortcut handling while IME composition is active via
event.isComposing.
File summaries
| File | Description |
|---|---|
frontend/src/app/page.tsx |
Move shortcut handling to capture-phase keydown and ignore IME composition events to improve shortcut reliability in packaged Tauri. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes keyboard shortcuts becoming unreliable in the packaged Tauri desktop app.
Changes
Testing
git diff --checkpasses.closes #214