Skip to content

fix: keyboard shortcuts in packaged app - #232

Open
Dhruv-Sharma29 wants to merge 1 commit into
petertzy:mainfrom
Dhruv-Sharma29:fix-keyboard-shortcuts
Open

fix: keyboard shortcuts in packaged app#232
Dhruv-Sharma29 wants to merge 1 commit into
petertzy:mainfrom
Dhruv-Sharma29:fix-keyboard-shortcuts

Conversation

@Dhruv-Sharma29

Copy link
Copy Markdown

Summary

Fixes keyboard shortcuts becoming unreliable in the packaged Tauri desktop app.

Changes

  • Register the global keyboard shortcut handler during the capture phase.
  • Prevent Monaco and WebView handlers from swallowing application shortcuts.
  • Ignore shortcuts while IME composition is active.
  • Preserve existing shortcut behavior in development mode.

Testing

  • git diff --check passes.
  • Frontend build could not be run because dependencies are not installed.

closes #214

Copilot AI lite review requested due to automatic review settings August 29, 2026 13:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Shortcut/event-order changes in a packaged desktop WebView context are hard to validate here (and the frontend build/tests were not run), so a human verification pass is warranted.

Pull request overview

This PR adjusts the frontend keyboard shortcut listener so application shortcuts remain reliable in the packaged Tauri desktop app, particularly when focus is inside Monaco/WebView-controlled elements.

Changes:

  • Register the window keydown listener in the capture phase to avoid missing events swallowed during bubbling.
  • Skip shortcut handling while IME composition is active via event.isComposing.
File summaries
File Description
frontend/src/app/page.tsx Move shortcut handling to capture-phase keydown and ignore IME composition events to improve shortcut reliability in packaged Tauri.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Keyboard Shortcuts in Packaged App

2 participants