Repository navigation
fix: remove Ctrl+L badge, fix nav shortcuts Ctrl+6-8, add Ctrl+H - #11
Merged
Merged
Conversation
SettingsView was calling ContentDialog.ShowAsync() directly on all 8 dialog calls (import flow, backup/restore, change password, error feedback). This caused COMException 0x80000019 when two dialogs overlapped — e.g. import error dialog shown before WinUI 3 fully released the previous merge-strategy dialog. All ShowAsync() calls now go through IDialogQueueService.EnqueueAndWait() using the same serial pump pattern already in place across all other ViewModels. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- KeyboardAcceleratorPlacementMode="Hidden" on NavigationView suppresses the automatic WinUI 3 tooltip badge that was floating indefinitely over the content area - NavShortcut_Invoked now filters MenuItems with OfType<NavigationViewItem>() to skip the NavigationViewItemSeparator (was occupying index 5, making Ctrl+6 select the separator and Ctrl+7 land on Generatore instead of Verifica) - Ctrl+8 added for Settings navigation - Ctrl+H added for Help/Guida navigation - HelpView and all 6 .resw files updated to document the new shortcuts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
dotnet build PassKey.sln -p:Platform=x64🤖 Generated with Claude Code