Skip to content

Fix/v1.0.4 localization empty state - #15

Merged
pexatar merged 2 commits into
mainfrom
fix/v1.0.4-localization-empty-state
Apr 30, 2026
Merged

pexatar merged 2 commits into
mainfrom
fix/v1.0.4-localization-empty-state

Conversation

@pexatar

@pexatar pexatar commented Apr 30, 2026

Copy link
Copy Markdown
Owner

Description

Brief description of the changes in this PR.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)

Testing

Describe the tests you ran to verify your changes.

  • All existing tests pass (dotnet test)
  • New tests added for new functionality
  • Solution builds without warnings (dotnet build PassKey.sln -p:Platform=x64)

Checklist

  • My code follows the project's code style guidelines
  • I have added XML documentation to all new public types and members
  • I have updated the CHANGELOG.md if applicable
  • My changes do not introduce new compiler warnings

pexatar and others added 2 commits April 27, 2026 15:37
actions/checkout@v4 and actions/setup-dotnet@v4 currently run on
Node.js 20, which is deprecated and will be removed on Sep 16 2026.
Adding FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true opts in early to
Node.js 24 before the forced migration deadline of Jun 2 2026.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…yButton

- EmptyStateControl: PrimaryButton and SecondaryButton now start Collapsed;
  visibility is toggled by OnPrimaryActionTextChanged / OnSecondaryActionTextChanged
  callbacks → eliminates the empty grey rectangle next to the blue button.

- Localization (6 languages): added 10 new resw keys per language
  (EmptyPasswordsSubtitle/PrimaryAction, EmptyCardsSubtitle/PrimaryAction,
  EmptyIdentitiesSubtitle/PrimaryAction, EmptyNotesSubtitle/PrimaryAction,
  EmptyFilteredTitle/Subtitle).

- PasswordsListView, CreditCardsListView, IdentitiesListView, SecureNotesListView:
  set empty-state Title/Subtitle/PrimaryActionText from ResourceLoader in
  SetViewModel() — guarantees correct language regardless of OS locale.

- ShellView: add KeyboardAcceleratorPlacementMode="Hidden" to NavLockVault
  NavigationViewItem to suppress Ctrl+L badge tooltip.

- Version bump 1.0.3 → 1.0.4 (csproj, iss, README).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pexatar
pexatar merged commit 750e9f9 into main Apr 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant