fix: publish PassKey.Desktop as truly self-contained (bundle .NET 10 … - #21
Merged
Merged
Conversation
…runtime) publish.ps1 was missing -r win-$Arch --self-contained true for the Desktop project. WindowsAppSDKSelfContained=true only bundles the Windows App SDK/WinUI 3 components, not the .NET base runtime. The generated runtimeconfig.json had "framework" (framework- dependent) instead of "includedFrameworks" (self-contained), causing the error: "You must install or update .NET to run this application. Required: Microsoft.NETCore.App, version 10.0.0 (x64)" Add -r win-$Arch --self-contained true to the Desktop publish command (same pattern already used for BrowserHost). The runtimeconfig.json now contains "includedFrameworks" confirming the .NET 10.0.7 runtime is bundled. Users no longer need to install .NET. Also bumps version to 1.0.7 and updates CHANGELOG/README/Installer accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pexatar
force-pushed
the
fix/self-contained-publish
branch
from
May 1, 2026 23:04
515de65 to
572898b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…runtime)
publish.ps1 was missing -r win-$Arch --self-contained true for the Desktop project. WindowsAppSDKSelfContained=true only bundles the Windows App SDK/WinUI 3 components, not the .NET base runtime. The generated runtimeconfig.json had "framework" (framework- dependent) instead of "includedFrameworks" (self-contained), causing the error:
"You must install or update .NET to run this application.
Required: Microsoft.NETCore.App, version 10.0.0 (x64)"
Add -r win-$Arch --self-contained true to the Desktop publish command (same pattern already used for BrowserHost). The runtimeconfig.json now contains "includedFrameworks" confirming the .NET 10.0.7 runtime is bundled. Users no longer need to install .NET.
Also bumps version to 1.0.7 and updates CHANGELOG/README/Installer accordingly.
Description
Brief description of the changes in this PR.
Type of change
Testing
Describe the tests you ran to verify your changes.
dotnet test)dotnet build PassKey.sln -p:Platform=x64)Checklist