Skip to content

Feat/browser extension store readiness - #29

Closed
pexatar wants to merge 5 commits into
mainfrom
feat/browser-extension-store-readiness
Closed

pexatar wants to merge 5 commits into
mainfrom
feat/browser-extension-store-readiness

Conversation

@pexatar

@pexatar pexatar commented May 14, 2026

Copy link
Copy Markdown
Owner

Description

Brief description of the changes in this PR.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)

Testing

Describe the tests you ran to verify your changes.

  • All existing tests pass (dotnet test)
  • New tests added for new functionality
  • Solution builds without warnings (dotnet build PassKey.sln -p:Platform=x64)

Checklist

  • My code follows the project's code style guidelines
  • I have added XML documentation to all new public types and members
  • I have updated the CHANGELOG.md if applicable
  • My changes do not introduce new compiler warnings

pexatar and others added 5 commits May 5, 2026 13:02
…XML docs

- CardTypeDetector: extract BinRanges nested class with 10 named constants
  for all BIN/IIN prefix ranges (MasterCard, Discover, JCB, Diners Club)
- PasswordStrengthAnalyzer: extract TimeConstants nested class (SecondsPerMinute
  through SecondsPerMillennium) replacing magic literals in EstimateCrackTime()
- PasswordGenerator: add MinPasswordLength=8 / MaxPasswordLength=128 constants
- MergeService: add NoteHashSnippetLength=256 constant; extract MergeCollection<T>()
  generic helper — eliminates 4 identical merge loops (~44 duplicated lines)
- Add Helpers/ListViewHelpers.cs with ShowSavedToast(TeachingTip, Action?)
  centralising identical toast boilerplate from 4 list-view code-behind files
- Rename _res → _resourceLoader in all 9 view files for naming clarity
- DashboardViewModel: add XML <summary> documentation to all 18 ObservableProperty
  declarations (greeting, stat cards, weekly activity, health, search)

Build: 0 errors, 0 warnings. Tests: 176/176 pass.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Chrome:
- Add CSP, author, homepage_url, full description, tabs permission
- Fix content_scripts matches (https/http only)
- Replace innerHTML SVG injection with DOMParser (CSP compliance)
- Fix stale tab ID in onFill() — re-query active tab at fill time
- Add rate limiting on Retry button
- Set document.lang dynamically from navigator.language

Firefox:
- Add tabs permission, host_permissions, Gecko UUID for AMO
- Same SVG/tab/retry/lang fixes as Chrome

Both:
- Add parseResponse() validation in all background.js handlers
- Fix French gender typo in i18n.js (Aucune → Aucun)
- Fix language fallback: Italian → English
- Remove hardcoded lang="it" from popup.html

Native Messaging:
- Update Firefox extension ID from dev placeholder to AMO UUID
- Split build-installer.ps1 into separate Chrome + Firefox manifests

Privacy Policy:
- Add docs/privacy/index.html (GitHub Pages: /PassKey/privacy)
- Update docs/privacy-policy.md: add tabs permission, update date

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the development key-derived ID with the ID assigned by the
Chrome Web Store (jadfnbfppmcpbfiickiolonfldkphmfb). Updates manifest
key field, NativeMessagingRegistrationService, BrowserHost manifest,
and build-installer script so all references stay consistent.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pexatar

pexatar commented May 14, 2026

Copy link
Copy Markdown
Owner Author

Closing — tutti i commit di questo branch sono già stati incorporati in main tramite PR #27, #28, #30. Il branch aveva conflitti irrisolvibili dovuti a merge commits locali duplicati. Il contenuto pertinente (Firefox data_collection_permissions, Chrome Extension ID update) è già su main.

@pexatar pexatar closed this May 14, 2026
@pexatar
pexatar deleted the feat/browser-extension-store-readiness branch May 14, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant