Repository navigation
fix: align assembly version with installer — bump to 1.0.15 - #35
Merged
Merged
Conversation
Root cause: PassKey.Desktop.csproj had <Version>1.0.12</Version> never updated. Every exe since v1.0.12 reported itself as "1.0.12" regardless of the installer version, causing the update checker to always suggest an update and the Settings page to always show "v 1.0.12". Changes: - PassKey.Desktop.csproj: Version/AssemblyVersion/FileVersion → 1.0.15 - Installer/PassKey.iss: AppVersion → 1.0.15 - Installer/PassKey.iss: add CloseApplications=yes + RestartApplications=yes to ensure the running PassKey.Desktop.exe is closed before file replacement Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
PassKey.Desktop.csprojhad<Version>1.0.12</Version>hard-coded and never updated.Every exe compiled since v1.0.12 (including v1.0.13 and v1.0.14) reported itself as
1.0.12at runtime, causing:Fix
PassKey.Desktop.csproj:Version/AssemblyVersion/FileVersion→1.0.15Installer/PassKey.iss:AppVersion→1.0.15Installer/PassKey.iss: addedCloseApplications=yes+RestartApplications=yesso the installer closes the running PassKey process before replacing
PassKey.Desktop.exe(prevents silent file-lock failures during in-place upgrade)
Test plan
🤖 Generated with Claude Code