Repository navigation
fix: tray context menu commands + ForceCreate race condition - #6
Merged
Merged
Conversation
- Replace Click event handlers on MenuFlyoutItem with x:Bind Command. H.NotifyIcon shows the flyout in a separate popup context; XAML event routing does not reach MainWindow handlers from there. RelayCommand via x:Bind resolves at compile-time on the MainWindow instance and is invoked directly — same pattern as DoubleClickCommand (confirmed working). TrayShowCommand / TrayLockCommand / TrayExitCommand. - Add HideToTray(): calls TrayIcon.ForceCreate() before AppWindow.Hide() to fix race condition where AppWindow.Hide() fired before the XAML visual tree loaded, preventing Shell_NotifyIcon from ever registering. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Click event handlers on MenuFlyoutItem with x:Bind Command. H.NotifyIcon shows the flyout in a separate popup context; XAML event routing does not reach MainWindow handlers from there. RelayCommand via x:Bind resolves at compile-time on the MainWindow instance and is invoked directly — same pattern as DoubleClickCommand (confirmed working). TrayShowCommand / TrayLockCommand / TrayExitCommand.
Add HideToTray(): calls TrayIcon.ForceCreate() before AppWindow.Hide() to fix race condition where AppWindow.Hide() fired before the XAML visual tree loaded, preventing Shell_NotifyIcon from ever registering.
Description
Brief description of the changes in this PR.
Type of change
Testing
Describe the tests you ran to verify your changes.
dotnet test)dotnet build PassKey.sln -p:Platform=x64)Checklist