Updated enrichment age tracer code. Improved its documentation throug…#19
Open
arwetzel wants to merge 1 commit into
Open
Updated enrichment age tracer code. Improved its documentation throug…#19arwetzel wants to merge 1 commit into
arwetzel wants to merge 1 commit into
Conversation
…hout. Set default age max to 13.7 Gyr. Fixed bug in dealing with events that cross multiple age bins. Fixed bug so it does not over-write a user's GALSF_FB_FIRE_AGE_TRACERS in gizmo parameters if you also set FIRE_PHYSICS_DEFAULTS. It now better handles the first and last age bins. For first age bin, fixed bug that Gizmo includes star particles with age < age_min in injecting element age tracer weights, but it did not use ages < age_min in computing the normalization of the weights, so it overestimated all weights in the first age bin. For the final age bin, now include star particles older than age_max in injecting their weights into the final bin, similar to the behavior for the youngest age bin, and ensuring that all star particles get counted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated enrichment age tracer module, with improved documentation. Set default age max to 13.7 Gyr. Fixed bug in dealing with events that cross multiple age bins. Fixed bug so it does not overwrite a user's GALSF_FB_FIRE_AGE_TRACERS in gizmo parameters if you also set FIRE_PHYSICS_DEFAULTS. For the first age bin, fixed bug that Gizmo includes star particles with age < age_min in injecting element age tracer weights, but it did not use ages < age_min in computing the normalization of the weights, so it overestimated all weights in the first age bin. For the final age bin, now include star particles older than age_max in injecting their weights into the final bin, similar to the behavior for the youngest age bin, and ensuring that all star particles get counted.