Skip to content

Fixed an issue where ALT+F5 for execute query in Query Tool shows cro…#9763

Merged
khushboovashi merged 1 commit intopgadmin-org:masterfrom
anilsahoo20:GH-9570
Mar 27, 2026
Merged

Fixed an issue where ALT+F5 for execute query in Query Tool shows cro…#9763
khushboovashi merged 1 commit intopgadmin-org:masterfrom
anilsahoo20:GH-9570

Conversation

@anilsahoo20
Copy link
Copy Markdown
Contributor

@anilsahoo20 anilsahoo20 commented Mar 18, 2026

…sshairCursor icon for rectangularSelection. #9570

Summary by CodeRabbit

  • Bug Fixes
    • Rectangular selection in the code editor now requires both Alt and Ctrl keys.
    • Crosshair cursor in the code editor now activates only when the Control key is pressed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f765b02b-9d8a-400f-8b06-1d2eca6859b2

📥 Commits

Reviewing files that changed from the base of the PR and between f0abe2b and 69d18e0.

📒 Files selected for processing (1)
  • web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx

Walkthrough

Editor.jsx updates CodeMirror extensions: rectangularSelection is now triggered only when both Alt and Ctrl are pressed, and crosshairCursor is constrained to the Control key.

Changes

Cohort / File(s) Summary
ReactCodeMirror Extension Configuration
web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx
Changed rectangularSelection() to use eventFilter requiring e.altKey && e.ctrlKey; changed crosshairCursor() to be key-scoped via { key: 'Control' }.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing an issue where ALT+F5 shows a crosshair cursor incorrectly during rectangular selection in the Query Tool.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@khushboovashi khushboovashi merged commit 3598840 into pgadmin-org:master Mar 27, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants