Open
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (14)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdated the Swedish pgAdmin translation catalog ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/pgadmin/translations/sv/LC_MESSAGES/messages.po`:
- Line 11: Find the translation entry whose msgid/msgstr pair has mismatched
positional placeholders (the one reported by the placeholder-balance check) and
edit the msgstr so its placeholders exactly match the msgid in both count and
position (e.g., use the same %s, %d or numbered forms like %1$s/%2$d in the same
order). Make sure not to remove or reorder placeholders; if the source uses
numbered placeholders, mirror those numbers in the Swedish msgstr, and then
re-run the translation checks (msgfmt or the project’s pipeline) to confirm the
placeholder-balance error is resolved.
- Line 5006: Summary: Fix the typo in the translation reference where "pgladmin"
should be "pgadmin". Edit the reference line that currently begins with "#:
pgladmin/browser/server_groups/servers/databases/schemas/views/static/js/view.js:55"
in messages.po and change "pgladmin" to "pgadmin" so the path reads "#:
pgadmin/...", and scan the file for any other occurrences of "pgladmin" to
correct them similarly.
- Line 7413: Replace the misspelled Swedish translation string msgstr "Nästad
tabell" with the correct wording "Nästlad tabell" for the "Nested Table" entry
(update the msgstr value for the translation keyed by the corresponding msgid
for "Nested Table").
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7097d0b7-1068-498d-99aa-f390fb86b8c4
📒 Files selected for processing (1)
web/pgadmin/translations/sv/LC_MESSAGES/messages.po
| "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n" | ||
| "POT-Creation-Date: 2026-02-26 18:55+0530\n" | ||
| "PO-Revision-Date: 2025-06-09 15:34+0200\n" | ||
| "PO-Revision-Date: 2026-03-18 15:22+0100\n" |
There was a problem hiding this comment.
Fix the failing placeholder-balance check before merge.
The translation pipeline is currently failing with positional format placeholders are unbalanced (reported at Line 825 in this file). Please fix the affected msgstr so its positional placeholders exactly match the corresponding msgid.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/pgadmin/translations/sv/LC_MESSAGES/messages.po` at line 11, Find the
translation entry whose msgid/msgstr pair has mismatched positional placeholders
(the one reported by the placeholder-balance check) and edit the msgstr so its
placeholders exactly match the msgid in both count and position (e.g., use the
same %s, %d or numbered forms like %1$s/%2$d in the same order). Make sure not
to remove or reorder placeholders; if the source uses numbered placeholders,
mirror those numbers in the Swedish msgstr, and then re-run the translation
checks (msgfmt or the project’s pipeline) to confirm the placeholder-balance
error is resolved.
Contributor
|
Please fix coderabittai review comments and translation builds are failing |
yeager
pushed a commit
to yeager/pgadmin4
that referenced
this pull request
Mar 26, 2026
- Keep JSON field names (role, admin, inherit, provider, label) untranslated - Fixes format string mismatch flagged by CodeRabbitAI - Resolves placeholder validation errors in PR pgadmin-org#9764
Contributor
|
Hi @yeager, please rebase your branch and also resolve the Coderabbitai review comments. |
yeager
pushed a commit
to yeager/pgadmin4
that referenced
this pull request
Mar 27, 2026
- Keep JSON field names (role, admin, inherit, provider, label) untranslated - Fixes format string mismatch flagged by CodeRabbitAI - Resolves placeholder validation errors in PR pgadmin-org#9764
yeager
force-pushed
the
update-swedish-translation
branch
from
c071715 to
6e5be69
Compare
added 4 commits
March 28, 2026 08:28
- Fix terminology: 'bord' → 'tabell' throughout - Fix placeholder errors in format strings - Remove fuzzy flag from header - Standardize database terminology (Vy, Tabellrymd, Utlösare) - 3625 translated strings, professional DBA review
- Keep JSON field names (role, admin, inherit, provider, label) untranslated - Fixes format string mismatch flagged by CodeRabbitAI - Resolves placeholder validation errors in PR pgadmin-org#9764
Add comma before 'och' after %SCHEMA% to prevent babel from misinterpreting '% o' as a positional format placeholder.
- Restore missing colons in security label JSON templates (label: <label>) - Restore untranslatable JSON keys in config variable templates (database, name, value should remain as English JSON keys)
yeager
force-pushed
the
update-swedish-translation
branch
from
87a2ea7 to
68f174e
Compare
Contributor
Author
|
Rebased on latest master and fixed the placeholder issue (added comma after %SCHEMA%/%USERNAME% etc. to prevent babel from interpreting
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swedish Translation Update
Changes
Stats
Context
Swedish translation was reviewed and corrected by a professional translator with PostgreSQL DBA experience. All database-specific terminology follows established Swedish standards.
Summary by CodeRabbit