include more headers - #2377
Open
usamoi wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
It seems that PostgreSQL 14 and earlier versions do not mark all variables as Probably we can temporarily exclude these problematic headers. Once support for PostgreSQL 14 is dropped by pgrx, we can add them back. Edit: It seems that too many problematic headers are already being included. Since we cannot remove the problematic headers that are already in use, we could instead remove only the |
usamoi
force-pushed
the
headers
branch
2 times, most recently
from
September 13, 2026 14:28
ec08824 to
78debf0
Compare
usamoi
force-pushed
the
headers
branch
2 times, most recently
from
September 13, 2026 14:31
65d2c7e to
8813c40
Compare
usamoi
marked this pull request as ready for review
September 13, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes pgrx include more headers. The ultimate goal is to include all headers to avoid the awkward situation where pgrx is missing the header files required by extensions.
Now all
./pgrx-pg-sys/include/pg*.hare generated byfix macos ci only: #2378