-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add type safety for skippable step dependencies #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 01-06-add_containmentpattern_t_type_for_type-safe_condition_options_in_dsl
Are you sure you want to change the base?
Conversation
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit af7d04a
☁️ Nx Cloud last updated this comment at |
14ed89d to
af7d04a
Compare
2b3cca7 to
966c7d1
Compare

Add Type Safety for Skippable Step Dependencies
This PR enhances the Flow DSL's type system to properly handle skippable steps. When a step has
whenUnmet: 'skip'orwhenFailed: 'skip', dependent steps now receive that step's output as an optional property in their dependencies object.Key improvements:
StepMetainterface to track both output type and skippability statusStepInputto make dependencies optional when they come from skippable stepsThis change improves type safety by preventing runtime errors when accessing potentially undefined outputs from skipped steps. Developers will now get proper TypeScript errors if they try to access properties on skippable dependencies without first checking for their existence.
Example usage: