This repository was archived by the owner on Oct 1, 2020. It is now read-only.
When running londiste replay --rewind you'd get an exception because the#40
Open
martinmarques wants to merge 2 commits intopgq:skytools_2_1_stablefrom
Open
When running londiste replay --rewind you'd get an exception because the#40martinmarques wants to merge 2 commits intopgq:skytools_2_1_stablefrom
martinmarques wants to merge 2 commits intopgq:skytools_2_1_stablefrom
Conversation
python code would use a function called pgq.register_consumer_at which doesn't exist in skytools v2, but does in v3. This fix just by-passes the calls to the non-existing function (which will now exist) to the pgq.register_consumer function with 3 input parameters, which does exist (and was renamed to pgq.register_consumer_at in skytools v3).
Also found a variable name mistaken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python code would use a function called pgq.register_consumer_at which
doesn't exist in skytools v2, but does in v3.
This fix just by-passes the calls to the non-existing function (which
will now exist) to the pgq.register_consumer function with 3 input
parameters, which does exist (and was renamed to pgq.register_consumer_at
in skytools v3).