fix: implement Flush on trackingResponseWriter#34
Open
pinginfo wants to merge 1 commit into
Open
Conversation
Allows the trackingResponseWriter to properly proxy flush requests to the underlying http.Flusher. This ensures compatibility with streaming responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Add
http.Flusherinterface implementation totrackingReponseWriterso that streaming handlers likeListenBucketNotificationcontinue to work when the double-response guard is active.Commit 52eee5a introduced
trackingReponseWriteto prevent double HTTP responses on a single request. HowevertrackingReponseWriterdid not implement thehttp.Flusherinterface. This causedxhttp.Flush(w)which uses a type assertionw.(http.Flushed)to become a no-op when the wrapper was active. As a result, streaming handlers likeListenBucketNotification(used bymcli watch) would buffer event data indefinitely without ever flushing it to the client, making the notification listener appear broken.Motivation and Context
ListenBucketNotificationuses a long-lived HTTP connection with Server-Sent Events. After writing each event, it callsxhttp.flush(w)to immediately push data to the client. Withouthttp.FlusherontrackingResponseWriter, the flush was silently skipped, and events never reached the client.How to test this PR?
mcli watch myminio/bucketTypes of changes
Checklist: