fix: run source phui with the Solid JSX preload - #28
Merged
Merged
Conversation
The bun-linked `phui` command spawned `bun src/standalone.ts` without @opentui/solid/preload, so JSX never transformed and the TUI froze on the splash while gh kept running. Also skip the Projects GitHub fan-out until that tab is actually selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Typing `phui` on this machine hits the bun-linked checkout, not Homebrew. The wrapper ran `bun src/standalone.ts` without `@opentui/solid/preload`. First paint stuck on the splash; atom updates never applied. Looks frozen. Meanwhile Projects (if constructed) fans out `gh` per local repo.
What
Verified: PATH `phui` now shows the PR list and `j` moves selection. 798 tests pass.