feat(videos): browse + download PS5 gameplay video clips (#97)#177
Merged
Conversation
Adds a "Video clips" screen mirroring Screenshots for gameplay video captures — the video counterpart users asked for. Checkbox multi-select, per-row + bulk download to the host, and an inline <video> preview (desktop). Clips are already playable formats, so unlike screenshots there's no .jxr → PNG conversion step. Full stack, all additive (a new frame — no change to existing paths): - payload/src/runtime.c: FTX2_FRAME_LIST_VIDEOS (166/167) + walk_videos() (walks /user/av_contents/video for .webm/.mp4/.mov, same JSON shape as walk_screenshots) + handle_list_videos dispatch. Builds -Werror. - ftx2-proto: ListVideos/ListVideosAck FrameType variants + decode arm. - ps5upload-core/saves.rs: list_videos() (reuses ScreenshotList type). - src-tauri: videos_list Tauri command + registration. - client/api/ps5.ts: videosList() wrapper. - client/screens/Videos: the screen (reuses startTransferDownload + stale-host guard + host-change reset patterns from Screenshots). - App.tsx route + Sidebar nav entry. - en.ts + i18n-known-missing.json: 16 keys, allowlisted for all 17 locales. HW NOT CONFIRMED: the exact av_contents/video path + extension set is the documented Sony layout but hasn't been verified against a live console (mirrors the screenshot bug where a wrong extension listed 0 files). If the Clips tab is empty with clips present, adjust walk_videos()'s root / extension filter in runtime.c — clearly commented there. payload -Werror + engine fmt/clippy/test + client typecheck/lint/763 tests/i18n(18)/build all green. Desktop fmt on my files clean (a stray local-rustfmt diff in an untouched file is a version-skew false positive; that file is byte-identical to CI-green main). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #97 — a Video clips screen, the video counterpart of the existing Screenshots screen. Lists gameplay video captures from the PS5, with checkbox multi-select, per-row + bulk download to your computer, and an inline
<video>preview (desktop). Unlike screenshots (HDR.jxrneeding PNG conversion), clips are already playable formats and download as-is.Full stack — all additive (a new frame, no change to existing paths)
payload/src/runtime.c—FTX2_FRAME_LIST_VIDEOS(166/167) +walk_videos()(walks/user/av_contents/videofor.webm/.mp4/.mov, same{path,size,mtime}JSON aswalk_screenshots) + dispatch. Builds-Werror.ftx2-proto—ListVideos/ListVideosAckvariants + decode arm.ps5upload-core/saves.rs—list_videos()(reuses theScreenshotListtype — identical shape).src-tauri—videos_listTauri command + registration.client/api/ps5.ts—videosList().client/screens/Videos— the screen (reusesstartTransferDownload+ the stale-host guard + host-change-reset patterns from Screenshots).App.tsxroute +Sidebarnav entry.The exact on-console
av_contents/videopath +.webm/.mp4extension set is the documented Sony layout but hasn't been verified against a live console in-house — this mirrors the historical screenshot bug where a wrong extension listed 0 files. If the Clips tab is empty with clips present, the fix is to adjustwalk_videos()'s root / extension filter inruntime.c(clearly commented there). Everything else (download, preview, selection) reuses proven screenshot plumbing.Type of Change
Testing
payload
-Werrorbuild + engine fmt/clippy/test + client typecheck/lint/763 tests/i18n(18 langs)/vite build all green.Closes #97.
🤖 Generated with Claude Code