Conversation
dgkf
approved these changes
Aug 20, 2026
dgkf
left a comment
dgkf
left a comment
Contributor
There was a problem hiding this comment.
Finally getting around to reviewing this and it looks great!
You also discovered a bug with the environment passing! I had to add a force() in order to avoid the need to explicitly pass your evaluation environment, so this should avoid that pitfall for future filters.
I'd still love to see composable filters, ie
cooldown <- package_filter(as.Date(Published) > Sys.Date() - 14)
good_docs <- package_filter(...)
established_w_good_docs <- package_filter(cooldown() & good_docs())but I think that's a bigger lift than we can manage with this PR.
github-project-automation
Bot
moved this from In Progress
to Done
in Package Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a small filter that is not about validation of packages but I wanted to test how it worked.
It adds a cooldown filter that prevents installing recently release packages (<= 2 weeks by default).
Currently it works in the sense that the packages are filtered but the data.frame returned is still the full one..
One needs to check the
"Include"column to check which packages were filtered