Skip to content

Use path without file:// - #49

Merged
dgkf merged 1 commit into
mainfrom
random_repo
Aug 23, 2026
Merged

dgkf merged 1 commit into
mainfrom
random_repo

Conversation

@llrs-roche

Copy link
Copy Markdown
Contributor

On my windows machine I cant' create.dir(random_repo(n=1), recursive = TRUE) if there is a file:// prefix on the path.
This PR removes it and uses the forward slash for Windows as I found that is what file.path() uses and creates less problems on windows.

This function is not covered by any tests, let me know if I add some tests for it

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 31.31%. Comparing base (c4d4e59) to head (b7829eb).

Files with missing lines Patch % Lines
R/class_pkg.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   31.31%   31.31%           
=======================================
  Files          36       36           
  Lines        1587     1587           
=======================================
  Hits          497      497           
  Misses       1090     1090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dgkf dgkf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving on the Windows side!

@dgkf
dgkf merged commit 9403f40 into main Aug 23, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Package Development Aug 23, 2026
@dgkf
dgkf deleted the random_repo branch August 23, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants