Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 31.31% 39.27% +7.95%
==========================================
Files 36 36
Lines 1587 1604 +17
==========================================
+ Hits 497 630 +133
+ Misses 1090 974 -116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
llrs-roche
reviewed
Sep 14, 2026
llrs-roche
left a comment
Contributor
There was a problem hiding this comment.
Nice solution, just one comment.
I like the second test where it uses a repo to really test that it works in practice. Thanks!
| test_that("metric_coerce coerces character metrics to each atomic type", { | ||
| ms <- metrics() | ||
|
|
||
| # integer metric |
Contributor
There was a problem hiding this comment.
The expectations don't explicitly state the class expected. I think it would be better if it used expect_type()
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #58