Skip to content

Conversation

@KOBANAK
Copy link
Collaborator

@KOBANAK KOBANAK commented Jul 22, 2025

Issue

Closes #476

Description

Create mean plots for both LOG and LIN scale

Definition of Done

The requirements for the feature to be complete:

  • mean plots created using tern g_lineplot function, handling LOG and LIN scales
  • Correct implementation of BLQ rule to display timepoints
  • flexible summary statistics selection
  • flexible whisker selection

How to Test:

Try both main dummy data set (with no AVALC) and the example-duplicates-ADNCA in test folder, which contains AVALC. In this file, I have added BLQ values for all NFRLT = 4 in the first dose, so these should be removed in the TLG mean plot.
Check that the mean linear plot renders and that the options are working as expected.

Contributor checklist

  • Code passes lintr checks
  • Code passes all unit tests
  • New logic covered by unit tests
  • New logic is documented
  • Package version is incremented

Notes to reviewer

@js3110 taken over December 23
/!\ On the meanplots, points from a same group were not linked to each other, geom_line within g_lineplot does not seem to work well when plotly obejct is created, to solve this I have just explicitly added a geom_line call, but not sure if this is the best approach!
Test the BLQ handling in mean plots with test-duplicate-ADNCA.csv

@KOBANAK KOBANAK linked an issue Jul 22, 2025 that may be closed by this pull request
4 tasks
@Shaakon35
Copy link
Collaborator

@KOBANAK Might be conflicting with #540 when it will be merged, be careful

@Gero1999
Copy link
Collaborator

Hey @KOBANAK I need more context to understand the original issue, what do you mean with

Correct implementation of BLQ rule to display timepoints

@KOBANAK
Copy link
Collaborator Author

KOBANAK commented Jul 23, 2025

Hey @KOBANAK I need more context to understand the original issue, what do you mean with

Correct implementation of BLQ rule to display timepoints
Hey @Gero1999 so a timepoint would be retained for plotting only if 50% or more of the samples of this group are non BLQ samples.

@js3110 js3110 marked this pull request as draft December 23, 2025 13:52
@js3110 js3110 marked this pull request as ready for review December 23, 2025 15:06
@js3110 js3110 requested a review from m-kolomanski December 23, 2025 15:38
@js3110 js3110 self-assigned this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Add mean plots with correct BLQ rule

6 participants