Bug fix: allow unknown units in AVALU and DOSEU #861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #836
Description
If units are not known by the
unitspackage, the app was crashing due to thesimplify_unitsfunction for simplifying the volume units. I have updated this function to return a warning rather than stop if the units are not recognised, so that more non-traditional units (eg cells) can still be used.Definition of Done
How to test
Using
dummy_RO_cellsintestthat/datafolder, run through and check that the app doesn't crash with the units, or try your own dataset with different units.Contributor checklist
Notes to the Reviewer
I have added the dummy dataset to make it easier to test, we can remove it before I merge or keep it for testing purposes, let me know what you think is best :)