Skip to content

docs(manabrew-compat): correct the capability-registry counts #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewevans merged 1 commit into from
Jul 27, 2026
Merged

docs(manabrew-compat): correct the capability-registry counts #6704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/manabrew-compat/CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ rg -o '"(local|upstream)\.[a-z0-9-]+"' crates/manabrew-compat/src/lib.rs | sort

Compare emitted codes against declared entries. Divergence is a defect, not a backlog item.

The registry is now **exhaustive** over emitted codes (78 declared; 65 emitted at live call sites, plus 13 documentary entries that describe a gap without a code path). `no_emitted_capability_code_is_undeclared` scans the production half of `lib.rs` and fails on any new undeclared code, so this no longer needs a manual audit — but re-run the command above if you doubt the test.
The registry is now **exhaustive** over emitted codes (82 declared; 69 emitted at live call sites, plus 13 documentary entries that describe a gap without a code path). `no_emitted_capability_code_is_undeclared` scans the production half of `lib.rs` and fails on any new undeclared code, so this no longer needs a manual audit — but re-run the command above if you doubt the test.

@coderabbitai coderabbitai Bot Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Do not claim that manual auditing is no longer needed.

no_emitted_capability_code_is_undeclared only verifies that scanned emitted literals are declared; its distinct.len() >= 50 floor does not enforce 69 emitted codes, 82 registry entries, or 13 documentary-only entries. The documented counts can therefore drift while the test remains green. Either narrow this sentence to the guarantee actually enforced, or add exact count assertions in crates/manabrew-compat/src/lib.rs:8294-8357.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/manabrew-compat/CLAUDE.md` at line 60, Update the documentation around
no_emitted_capability_code_is_undeclared to avoid claiming manual audits are
unnecessary; describe only the guarantee the test actually enforces.
Alternatively, strengthen that test with exact assertions for the 69 emitted
codes, 82 registry entries, and 13 documentary-only entries, then retain the
claim only if those counts are enforced.

Source: Path instructions


### 4. A mapping claim must be exhibited by a test, not asserted in prose.

Expand Down
Loading