ship/fix ai validate restored and target continuations

[matthewevans]

• fix(ai): validate restored and target continuations
• test(ai): cover target surcharge proposal boundary

Summary by CodeRabbit

• Bug Fixes
  • Restored games and multiplayer sessions now fail safely when required card data is unavailable, without partially changing game state.
  • Resumed and restored games better preserve card details, random sequences, and replay validity.
  • AI target selection no longer offers outdated or invalid targets.
  • AI correctly excludes unpayable actions while retaining valid alternatives.
  • Players can cancel eligible casts during target selection.
  • AI fallback behavior now consistently follows issued legal actions and handles no-target scenarios correctly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5607db23-d866-4bce-afef-57db5245bce3

📥 Commits

Reviewing files that changed from the base of the PR and between fe67e0f and e41dffb.

📒 Files selected for processing (1)

• crates/phase-ai/src/policies/hand_disruption.rs

💤 Files with no reviewable changes (1)

• crates/phase-ai/src/policies/hand_disruption.rs

---

📝 Walkthrough

Walkthrough

Restoration and multiplayer resume now require card-database rehydration. AI target candidates now use current prompts and reducer validation. Fallback actions consume issued decision-contract candidates. WASM tests cover restoration, payment legality, legacy states, replay invalidation, and RNG continuity.

Changes

State restoration

Layer / File(s)	Summary
Mandatory card-database rehydration crates/engine-wasm/src/lib.rs	Restore and multiplayer resume paths rehydrate restored state and fail before state mutation when no card database is loaded.
WASM restoration fixtures and coverage crates/engine-wasm/src/lib.rs	Fixtures and tests cover restored prompts, payment-dependent targets, legacy objects, replay invalidation, multiplayer resume, and RNG restoration.

Validated AI target actions

Layer / File(s)	Summary
Current target candidate enumeration crates/engine/src/ai_support/candidates.rs	Target selection uses current legal targets, preserves permitted CancelCast, and rejects stale target-slot entries.
Reducer-validated candidate contracts crates/engine/src/ai_support/context.rs, crates/engine/src/ai_support/mod.rs, crates/engine/src/game/casting.rs, crates/phase-ai/src/policies/hand_disruption.rs	Target-selection contracts use reducer validation when pending mana obligations can change. Supporting cost-stability logic and target-selection fixtures are updated.
Fallback use of issued actions crates/phase-ai/src/search.rs	fallback_action selects issued ChooseTarget and CancelCast candidates instead of rebuilding target actions.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant phase_ai_search
  participant AiDecisionContract
  participant legal_actions_full
  participant FilterPipeline
  phase_ai_search->>AiDecisionContract: request target decision
  AiDecisionContract->>legal_actions_full: enumerate current target actions
  legal_actions_full->>FilterPipeline: validate candidates
  FilterPipeline-->>AiDecisionContract: return legal candidates
  AiDecisionContract-->>phase_ai_search: issue ChooseTarget or CancelCast

Loading

sequenceDiagram
  participant Restore
  participant Rehydration
  participant CardDatabase
  participant GameState
  Restore->>Rehydration: restore state
  Rehydration->>CardDatabase: load card definitions
  CardDatabase-->>Rehydration: definitions or error
  Rehydration->>GameState: install rehydrated state

Loading

Possibly related PRs

• phase-rs/phase#6829: Extends the same AI decision-contract and proposal paths.
• phase-rs/phase#6741: Modifies related AI fallback handling in the search and WASM paths.
• phase-rs/phase#6973: Modifies related AI candidate validation and issued action handling.

Suggested labels: bug

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the main changes: AI validation for restored states and target continuations.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/fix-ai-validate-restored-and-target-continuations

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/engine-wasm/src/lib.rs`:
- Around line 1842-1844: In crates/engine-wasm/src/lib.rs#L1842-L1844, call
rehydrate_restored_state_from_card_db before rehydrate_rng and the debug_mode
assignment; in crates/engine-wasm/src/lib.rs#L1905-L1910, perform the same
card-database restoration before assigning the fresh RNG state. Ensure both
restoration paths validate required resources before any GameState mutation.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6648a541-38ea-490c-bceb-3c4d69e58426

📥 Commits

Reviewing files that changed from the base of the PR and between 4d27655 and f3307e7.

📒 Files selected for processing (5)

• crates/engine-wasm/src/lib.rs
• crates/engine/src/ai_support/candidates.rs
• crates/engine/src/ai_support/context.rs
• crates/engine/src/ai_support/mod.rs
• crates/phase-ai/src/search.rs

[github-actions]

Generated for head e41dffb63fbd8e60c4a15dbf5c71bb4b5ab813f6.

Parse changes introduced by this PR

✓ No card-parse changes detected.