-
-
Notifications
You must be signed in to change notification settings - Fork 153
Fix Scythecat Cub #7220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix Scythecat Cub #7220
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
crates/engine/tests/integration/scythecat_cub_second_resolution.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| //! Scythecat Cub doubles the counters placed by its second landfall resolution. | ||
|
|
||
| use engine::game::scenario::{GameScenario, P0}; | ||
| use engine::types::ability::TargetRef; | ||
| use engine::types::actions::GameAction; | ||
| use engine::types::counter::CounterType; | ||
| use engine::types::game_state::WaitingFor; | ||
| use engine::types::phase::Phase; | ||
|
|
||
| const SCYTHECAT_CUB_ORACLE: &str = "Trample\n\ | ||
| Landfall — Whenever a land you control enters, put a +1/+1 counter on target creature you control. If this is the second time this ability has resolved this turn, double the number of +1/+1 counters on that creature instead."; | ||
|
|
||
| fn resolve_cub_landfall( | ||
| runner: &mut engine::game::scenario::GameRunner, | ||
| land_id: engine::types::identifiers::ObjectId, | ||
| target_id: engine::types::identifiers::ObjectId, | ||
| ) { | ||
| let card_id = runner.state().objects[&land_id].card_id; | ||
| runner | ||
| .act(GameAction::PlayLand { | ||
| object_id: land_id, | ||
| card_id, | ||
| }) | ||
| .expect("land should be playable"); | ||
|
|
||
| match &runner.state().waiting_for { | ||
| WaitingFor::TriggerTargetSelection { target_slots, .. } => { | ||
| assert!( | ||
| target_slots[0] | ||
| .legal_targets | ||
| .iter() | ||
| .any(|target| matches!(target, TargetRef::Object(id) if *id == target_id)), | ||
| "Lotus Cobra must be a legal Scythecat Cub target" | ||
| ); | ||
| } | ||
| other => panic!("expected Scythecat Cub target selection, got {other:?}"), | ||
| } | ||
|
|
||
| runner | ||
| .act(GameAction::ChooseTarget { | ||
| target: Some(TargetRef::Object(target_id)), | ||
| }) | ||
| .expect("Lotus Cobra should be selectable"); | ||
| runner.advance_until_stack_empty(); | ||
| } | ||
|
|
||
| #[test] | ||
| fn scythecat_cub_doubles_counters_on_second_landfall_resolution() { | ||
| let mut scenario = GameScenario::new(); | ||
| scenario.at_phase(Phase::PreCombatMain); | ||
|
|
||
| let cub_id = scenario | ||
| .add_creature_from_oracle(P0, "Scythecat Cub", 2, 2, SCYTHECAT_CUB_ORACLE) | ||
| .id(); | ||
| let cobra_id = scenario.add_creature(P0, "Lotus Cobra", 2, 1).id(); | ||
| let first_land_id = scenario.add_land_to_hand(P0, "First Land").id(); | ||
| let second_land_id = scenario.add_land_to_hand(P0, "Second Land").id(); | ||
|
|
||
| let mut runner = scenario.build(); | ||
| runner.state_mut().max_lands_per_turn = 2; | ||
| runner | ||
| .state_mut() | ||
| .objects | ||
| .get_mut(&cobra_id) | ||
| .expect("Lotus Cobra should start on the battlefield") | ||
| .counters | ||
| .insert(CounterType::Plus1Plus1, 1); | ||
|
|
||
| resolve_cub_landfall(&mut runner, first_land_id, cobra_id); | ||
| assert_eq!( | ||
| runner.state().objects[&cobra_id] | ||
| .counters | ||
| .get(&CounterType::Plus1Plus1) | ||
| .copied(), | ||
| Some(2), | ||
| "the first landfall resolution should place one +1/+1 counter on the seeded target" | ||
| ); | ||
|
|
||
| resolve_cub_landfall(&mut runner, second_land_id, cobra_id); | ||
| assert_eq!( | ||
| runner.state().objects[&cobra_id] | ||
| .counters | ||
| .get(&CounterType::Plus1Plus1) | ||
| .copied(), | ||
| Some(4), | ||
| "the second landfall resolution should double Lotus Cobra's counters" | ||
| ); | ||
| assert_eq!( | ||
| runner | ||
| .state() | ||
| .ability_resolutions_this_turn | ||
| .get(&(cub_id, 0)), | ||
| Some(&2), | ||
| "both landfall triggers should share Cub's printed ability index" | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.