Skip to content

test(ai): capture priority fallback saved state - #7310

Merged
matthewevans merged 2 commits into
mainfrom
ship/test-ai-capture-priority-fallback-saved-state
Aug 12, 2026
Merged

test(ai): capture priority fallback saved state#7310
matthewevans merged 2 commits into
mainfrom
ship/test-ai-capture-priority-fallback-saved-state

Conversation

@matthewevans

@matthewevans matthewevans commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests

    • Added coverage for community scenarios involving failed proposals and priority handling.
    • Updated performance benchmark baselines and measurement metadata to reflect current results.
  • Chores

    • Refreshed benchmark counters while preserving the existing configuration and data format.

@matthewevans
matthewevans enabled auto-merge August 12, 2026 19:32
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fe1a7fa8-2a11-406b-8f3e-be2f55d85bd1

📥 Commits

Reviewing files that changed from the base of the PR and between b620a33 and 5533bdb.

⛔ Files ignored due to path filters (1)
  • crates/phase-ai/fixtures/scenarios/game-state-turn-22-2026-08-08T05-28-08-309Z.zip is excluded by !**/*.zip
📒 Files selected for processing (2)
  • crates/phase-ai/baselines/perf-baseline.json
  • crates/phase-ai/fixtures/scenarios/community-scenarios.json

📝 Walkthrough

Walkthrough

The pull request refreshes performance baseline metadata and counters. It also adds the priority-failed-proposals community scenario fixture with its expected PassPriority action.

Changes

Performance baseline refresh

Layer / File(s) Summary
Baseline metadata and counters
crates/phase-ai/baselines/perf-baseline.json
The baseline Git commit, card-data hash, performance counters, legality clone count, and wall-clock time were updated.

Community scenario fixture

Layer / File(s) Summary
Priority-failed proposals fixture
crates/phase-ai/fixtures/scenarios/community-scenarios.json
The fixture defines the associated thread, archive, and expected PassPriority action.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: quality

Suggested reviewers: lgray

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the added AI scenario fixture that captures priority fallback behavior and saved state.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship/test-ai-capture-priority-fallback-saved-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans force-pushed the ship/test-ai-capture-priority-fallback-saved-state branch from 5533bdb to a1be22c Compare August 12, 2026 20:15
@matthewevans
matthewevans added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit 479ad39 Aug 12, 2026
19 checks passed
@matthewevans
matthewevans deleted the ship/test-ai-capture-priority-fallback-saved-state branch August 12, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant