test(engine): cover Overencumbered token ownership

[matthewevans]

Fixes #5271.

Adds a production cast → attach → ETB regression for Overencumbered, proving each shared-sequence token belongs to and is controlled by the enchanted opponent. Also corrects the Aura-host CR citation.

Summary by CodeRabbit

• Bug Fixes

  • Corrected token ownership and control when the Overencumbered Aura creates Clue, Food, and Junk tokens for an enchanted opponent.

• Tests

  • Added integration coverage to verify the corrected token behavior across all three token types.

• Documentation

  • Updated rules references for enchanted-player subject parsing, including CR 303.4m.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5fa8187b-7315-4483-9779-9ae1d8c4a69d

📥 Commits

Reviewing files that changed from the base of the PR and between 60fa689 and 5e5af85.

📒 Files selected for processing (1)

• crates/engine/tests/integration/issue_5271_overencumbered_tokens.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/engine/tests/integration/issue_5271_overencumbered_tokens.rs

---

📝 Walkthrough

Walkthrough

The PR updates an enchanted-opponent parsing comment and adds an integration test for Overencumbered. The test verifies ownership and control for generated Clue, Food, and Junk tokens.

Changes

Overencumbered regression

Layer / File(s)	Summary
Enchanted-opponent rule reference crates/engine/src/parser/oracle_effect/subject.rs	The explanatory comment updates its cited rules. Parsing behavior remains unchanged.
Token ownership regression test crates/engine/tests/integration/issue_5271_overencumbered_tokens.rs, crates/engine/tests/integration/main.rs	Adds and registers an integration test that verifies Overencumbered gives Clue, Food, and Junk tokens to the enchanted opponent.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 5e5af

This localized change adds regression coverage and corrects a citation; no actionable merge-blocking risk remains.

Possibly related PRs

• phase-rs/phase#6323: Updates related CR 608.2i parsing documentation.
• phase-rs/phase#7303: Changes related CR 303.4g Aura-entry handling.
• phase-rs/phase#7326: Fixes enchanted-player/opponent token creators related to this regression.

Suggested labels: bug

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The CR citation correction is unrelated to issue #5271's Overencumbered token ownership behavior.	Move the CR citation correction to a separate pull request or link an issue that requires this documentation change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the engine regression test for Overencumbered token ownership.
Linked Issues check	✅ Passed	The integration test covers the opponent-cast scenario and verifies Clue, Food, and Junk token ownership and control for issue #5271.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/fix-overencumbered-runtime

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Generated for head 5e5af85d861d46b7d73e0c231794e9abbdf12054.

Parse changes introduced by this PR

✓ No card-parse changes detected.