fix(ci): Iterable from collections.abc + isort#73
Merged
Conversation
Two ruff failures kept CI red on main after the delete-safeguards merge (PR #62) and the path-consolidation merge (PR #72): - UP035: src/lose_it/backup/_upsert.py imported Iterable from typing. Pyupgrade rule says use collections.abc.Iterable. - I001: after the swap, the import block became un-sorted. Both fixed; ruff check is now clean. Tests stay at 276/276.
phitoduck
force-pushed
the
fix-ci-iterable-import
branch
from
1c7e368 to
beb2877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ruff failures that kept CI red on main after PR #62 and #72.
Also a follow-on I001 (import block un-sorted) auto-fixed by
ruff --fix.uv run ruff check .→ clean. Test suite stays at 276/276 green. Version bumped 0.8.0 → 0.8.1.