[Phoenix] Assault Promotion Block Module - #188
Open
KiplingFFXI wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR stops players from being able to rank up past Lance Corporal. We will launch with two tiers of assaults - Private First Class and Superior Private. However, we want to give players the option to earn credits while Superior Private and rank up. This means players will be able to achieve Lance Corporal rank, which gives them longer Sanction, but they will not be able to do Lance Corporal assaults until we enable them.
This PR functions by outright blocking access to all of the quests to be safe. Note that Promotion: Captain is not implemented in LSB yet so it is not listed here. It is not a risk because you also need to have completed TOAU 48, which will not be possible.
This module will be updated over time as we add new assault ranks. The plan is to let players rank up one tier further than the level of assaults we currently offer.
Steps to test these changes
Load the module. Get Lance Corporal. Get 25 assault points. See you can't begin the next quest.