feat: phx_web generate endpoint.ex with CheckRepoStatus plug migration_lock: false option#5153
Closed
cgrothaus wants to merge 1 commit intophoenixframework:masterfrom
Conversation
…ion_lock: false` option
Member
|
Given this is a dev feature I don't think we need specialized behavior and the current checks are preferred since they are more comprehensive? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
phx_webgenerator: generateCheckRepoStatusplug line with an option so that it runs without migration lock.Background
phoenixframework/phoenix_ecto#160 makes it possible to pass a
migration_lockoption toCheckRepoStatusplug. This plug is a convenience that checks for pending migrations. By default it uses the migration lock strategy defined in the OTP app ecto repo configuration. When that is configured to:pg_advisory_lock, concurrent requests indevenvironment may be delayed by 5s. See this elixir forum topic for more information.IMO just reading the pending migrations should be possible without any migration lock. Hence this PR adds the
migration_lock: falseconfig option toCheckRepoStatusplug.Dependencies
This PR depends on the changes in phoenixframework/phoenix_ecto#160, so first
phoenix_ectohas to be released.