Fixes: derivative of krb and bounded saturation equation#40
Open
eugenioidaea wants to merge 1 commit into
Open
Fixes: derivative of krb and bounded saturation equation#40eugenioidaea wants to merge 1 commit into
eugenioidaea wants to merge 1 commit into
Conversation
eugenioidaea
commented
Apr 10, 2026
- derivative of krb in krBrooksAndCorey.C was the same as the one defined for kra;
- saturation Sb drops below Sbmin in heterogeneous K fields and code crashes. Testing alternatives for saturation equation in SEqn.H: fvc::div(phib) -> fvm::div(phib, Sb)
Owner
|
Thank for the fix in krBrooksAndCorey.C Concerning the modifications of SEqn.H :
|
Author
|
Thanks for the reply! You're right about SEqn.H, if Sb is added it becomes redundant. About saturation dropping below Sbmin & code crashing after hours of simulations, do you have any recommendations to prevent it? I tried lowering Courant to 0.2 but it does not help :( |
Owner
|
This is not exactly the good place to discuss about this. Usually, this kind of problem occurs more with the van Genuchten model, which exhibits sharp fronts, than with the Brooks and Corey model. I would say that it is rather a problem of configuration (BC or flow properties). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.