Ci/add phpstan analysis - #55
Merged
Merged
Conversation
Add phpstan/phpstan as a dev dependency with a level 5 config (src/ only), bootstrap the ThinkPHP framework helper.php so app()/config()/config_path() are recognized, and inline-ignore the remaining false positives caused by think-orm's untyped fluent query builder methods. Run PHPStan as a step in the existing PHPUnit CI job (before the test suite) so a failing check blocks the job, and therefore also blocks semantic-release.
- import Throwable/LogicException instead of resolving them in the local namespace - add missing return in Publish::execute() - correct Configurable::config() $default PHPDoc type - simplify redundant is_null() checks proven dead code by phpstan
Member
Author
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.