fix: Preserve defaults and avoid type conflicts for polymorphic schemas #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes parameter-level Schema attribute handling to support both object and array notation for properties parameters. Two related schema generation issues resolved: 1. Parameter-level Schema attributes with 'definition' key now preserve PHP signature defaults when the definition omits one. Previously defaults were lost when using full definition overrides. 2. Schema merging removes inferred type constraints when anyOf/oneOf/allOf is present WITHOUT an explicit type in the dominant schema. This prevents conflicts where inferred "type": "array" from PHP type hints conflicts with anyOf allowing object notation, while respecting explicit type declarations. Includes test fixtures and integration coverage for parameter- and method-level anyOf schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parameter-level Schema attribute handling to support both object and array notation for properties parameters.
Resolves two related schema generation issues:
Parameter-level Schema attributes with 'definition' key now preserve PHP signature defaults when the definition omits one. Previously defaults were lost when using full definition overrides.
Schema merging removes inferred type constraints when anyOf/oneOf/allOf is present WITHOUT an explicit type in the dominant schema. This prevents conflicts where inferred "type": "array" from PHP type hints conflicts with anyOf allowing object notation, while respecting explicit type declarations.
Includes test fixtures and integration coverage for parameter- and method-level anyOf schemas.
P.S.:
composer lintwas NOT run, as it reformats a bunch of files on my system...