Support for xdebug in local development with docker#587
Open
ArgusKay99 wants to merge 2 commits intophparkitect:mainfrom
Open
Support for xdebug in local development with docker#587ArgusKay99 wants to merge 2 commits intophparkitect:mainfrom
ArgusKay99 wants to merge 2 commits intophparkitect:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=========================================
Coverage 98.12% 98.12%
Complexity 663 663
=========================================
Files 84 84
Lines 1923 1923
=========================================
Hits 1887 1887
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Request
Summary
Can we add xdebug to the docker-container? I created a multi-stage Dockerfile that can be built with and without xdebug.
For context: I am developing on linux with Phpstorm and use the the Docker-container that is created in the CONTRIBUTING.md file as remote PHP interpreter and when there is a xdebug installed, i can already debug unit-tests.
I'm open to suggestions to use xdebug in another way.
BC Break for local development:
docker image build will now need a target:
docker image build --target php_build -t phparkitect .