Restore support for phpdoc-parser ^1.2 alongside ^2.0#588
Merged
Conversation
The DocblockParserFactory already handles both versions via a runtime class_exists(ParserConfig::class) check. This commit simply broadens the composer constraint to allow installations with either v1.2+ or v2.x. https://claude.ai/code/session_01YZZi4mYn7d99QqxoRTUyvn
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
=========================================
Coverage 98.12% 98.12%
Complexity 663 663
=========================================
Files 84 84
Lines 1923 1923
=========================================
Hits 1887 1887
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fain182
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DocblockParserFactory already handles both versions via a runtime
class_exists(ParserConfig::class) check. This commit simply broadens
the composer constraint to allow installations with either v1.2+ or v2.x.
https://claude.ai/code/session_01YZZi4mYn7d99QqxoRTUyvn