[pull] main from NVIDIA:main#592
Merged
Merged
Conversation
* Handle empty tensors in dequantize for CUDA graph compatibility Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * dequant with swizzled scales Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * pass nvfp4 dequant tests Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * cleanup unit tests Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * remove allocation in set amax Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * Drop disabling `optimize_for_gemm` introduced in PR 2644 Signed-off-by: Ziang Li <ziangli@umich.edu> Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * Drop `optimize_for_gemm` in basic linear Signed-off-by: Ziang Li <ziangli@umich.edu> Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> * remove redundant set scale Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * rebase on nvfp4 test fix Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * remove redundant line Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * add missing from_cpu() for scale Signed-off-by: YigongQin <qqqyyy1233@outlook.com> * Remove unnecessary scale from NVFP4 C++ tests Signed-off-by: Tim Moon <tmoon@nvidia.com> --------- Signed-off-by: YigongQin <qqqyyy1233@outlook.com> Signed-off-by: Ziang Li <ziangli@umich.edu> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Ziang Li <ziangli@umich.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Co-authored-by: Tim Moon <tmoon@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )