Deduplicate TTS engine HTTP request scaffolding - #15
Open
phyceClaw wants to merge 2 commits into
Open
Conversation
- Add request timeouts to ElevenLabs and OpenAI HTTP clients (a hung endpoint no longer blocks a pooled instance forever) - Send the Gemini API key via the x-goog-api-key header instead of a URL query param (avoids leaking the key into logs/proxies/errors) - Reuse a single Google TextToSpeech client instead of creating one per request Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ElevenLabs, OpenAI and Gemini each hand-rolled the same marshal / new-request / set-headers / do / close / status-check / read-body sequence. Extract it into a shared httpapi.Do helper (with the timeout-bounded client) and route the four sendRequest/Fetch functions through it. Also drops leftover debug response.Success noise and a dead return in ElevenLabs.Play. Google is unchanged (it uses the gRPC SDK, not raw HTTP). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ElevenLabs, OpenAI and Gemini each hand-rolled the same JSON-over-HTTP sequence (marshal → new request → set headers → do → close → status check → read body). This extracts it into a small shared helper,
app/tts/engine/internal/httpapi, and routes the foursendRequest/Fetch*functions through it.httpapi.Do(Request)centralizes the request lifecycle and owns the single timeout-boundedhttp.Client.response.Success("...succeeded?")calls and a deadreturn nilafter a return inElevenLabs.Play(the onlygo vetwarning in the touched files).texttospeechgRPC SDK, not raw HTTP, so it does not fit this helper.Behavior is preserved: same endpoints, headers, 30s timeout, status handling, and error bodies.
This branches on top of #6 (Harden TTS engine HTTP clients), since both touch the same engine files. Until #6 merges, the diff here shows #6’s commit too — the net-new change is the single commit
Deduplicate TTS engine HTTP request scaffolding. Please merge after #6; it will then reduce to just the dedup.Testing
CGO_ENABLED=1 go build ./app/...passes;go vetclean on all touched packages.🤖 Generated with Claude Code