security: recover() in handshake connection handler + common v0.5.9 (panic-DoS) - #29
Merged
Merged
Conversation
…hardening) The handshake decodes a peer-supplied public_key and calls crypto.Verify; a wrong-length key made ed25519.Verify panic, and handleConnection runs in its own goroutine — an unrecovered panic there crashes the daemon. common v0.5.9 makes crypto.Verify reject wrong-length keys (root fix); the recover() is defense-in-depth against any future panic in this unauthenticated path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wrong-length
public_keyin a handshake message madeed25519.Verifypanic;handleConnectionruns in its own goroutine, so an unrecovered panic crashes the daemon (remote, unauthenticated). Fixed at the root in common v0.5.9 (crypto.Verifylength guard) and added arecover()here as defense-in-depth. Tests green.🤖 Generated with Claude Code