feat(hooks): gate trust grants through action hooks - #37
Merged
Merged
Conversation
Preservation snapshot of uncommitted working-tree work (repo survey 2026-08-02). WIP branch — do NOT push directly; split into reviewed PRs first. Build scratch excluded via .gitignore. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… amplification) M1: prepareTrustAction (a synchronous authority round-trip in managed-enforce mode) ran at the very top of handleRequest/processRelayedRequest, before the per-source and total pending caps (evaluated only under the lock afterward) and before the already-trusted fast return. Any node that could reach port 444 or relay a request thus forced one authority call per handshake and tied up a handler goroutine — defeating the per-source pending cap and enabling amplification against the operator's authority. Add fast pre-checks before the hook: an already-trusted peer (matching key) is accepted and over-cap/unqueued spam is rejected, both without invoking the hook. The authoritative trust and cap decisions remain under the lock below, so the pre-checks are a guard, not the enforcement — no change to who gets trusted. The relayed path never drops an already-trusted or already-pending peer. Regression test asserts the hook is not invoked for already-trusted peers or over-cap spam (direct and relayed); full trust suite green. SECURITY_REVIEW_v1.14 M1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification